Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom datetime hover conversion for Bokeh Raster plot #6039

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 18, 2023

Follow up to #6023, and remove the custom datetime implementation if Bokeh 3.4 is installed.

@hoxbro hoxbro added the type: compatibility Compability with upstream packages label Dec 18, 2023
@hoxbro hoxbro enabled auto-merge (squash) December 18, 2023 10:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ecab267) 88.65% compared to head (b8ed4a7) 88.52%.
Report is 1 commits behind head on main.

Files Patch % Lines
holoviews/tests/plotting/bokeh/test_rasterplot.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6039      +/-   ##
==========================================
- Coverage   88.65%   88.52%   -0.14%     
==========================================
  Files         315      315              
  Lines       65661    65666       +5     
==========================================
- Hits        58209    58128      -81     
- Misses       7452     7538      +86     
Flag Coverage Δ
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit 898c11f into main Dec 18, 2023
12 of 13 checks passed
@hoxbro hoxbro deleted the remove_custom_raster branch December 18, 2023 11:05
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: compatibility Compability with upstream packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants