Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): Avoid checking out CRLF in shell scripts #6484

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

stanwest
Copy link
Contributor

@stanwest stanwest commented Jan 7, 2025

This PR resolves issue #6482 by instructing git to check out "*.sh" files with LF line endings.

A shell script previously checked out with CRLF endings will need its endings changed by other means for linting to pass.

@hoxbro hoxbro changed the title chore: Avoid checking out CRLF in shell scripts fix(dev): Avoid checking out CRLF in shell scripts Jan 9, 2025
@hoxbro hoxbro linked an issue Jan 9, 2025 that may be closed by this pull request
1 task
@hoxbro
Copy link
Member

hoxbro commented Jan 9, 2025

Thank you.

@hoxbro hoxbro merged commit b8cd6d8 into holoviz:main Jan 9, 2025
9 checks passed
@stanwest stanwest deleted the shell-script-line-endings branch January 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "shellcheck" pre-commit hook fails with git configured with "autocrlf = true"
2 participants