Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support the case of multiple line segments each with one vdim #6492

Merged

Conversation

grapesmoker
Copy link
Contributor

Previously Path would accept data that was structured as a list of dictionaries, each dictionary representing a single line segment. Such lists would plot correctly but if you had any vdims defined on the dictionary, a warning would be raised when trying to create a ColumnDataSource because the _element_transform function would make it so that the list of vdims and the list of coordinates had different lengths. This PR fixes this issue, so a list of dictionaries, each with its own coordinates and vdims, is now allowed. The below screenshot illustrates the desired plot.

Screenshot 2025-01-16 at 4 42 01 PM

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (becb5f3) to head (ba8c018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6492   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         323      323           
  Lines       68696    68712   +16     
=======================================
+ Hits        60976    60992   +16     
  Misses       7720     7720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grapesmoker grapesmoker changed the title support the case of multiple line segments each with one vdim fix: support the case of multiple line segments each with one vdim Jan 17, 2025
@hoxbro
Copy link
Member

hoxbro commented Jan 17, 2025

Thank you for the PR 👍

@hoxbro hoxbro enabled auto-merge (squash) January 17, 2025 17:24
@hoxbro hoxbro merged commit 958b1c3 into holoviz:main Jan 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants