Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate to pixi #1470

Merged
merged 15 commits into from
Jan 22, 2025
Merged

ci: migrate to pixi #1470

merged 15 commits into from
Jan 22, 2025

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jan 20, 2025

This PR migrates the developer workflow to Pixi. This is pretty much aligned with what has already been done for most HoloViz packages, with some differences:

  • Adopted recommending using the default environment with pretty much all that is required to develop hvPlot (tests, jupyterlab, etc.), excluding building the docs (could be included). This approach was recently adopted by HoloViews. EDIT: With a bit more streamlined experience provided by pixi run install-dev (create env, editable install, set up pre-commit, download test datasets).
  • It didn't move yet to hatchling to build hvPlot as I don't want to mix things too much in this PR that is already big enough.
  • It doesn't include the "Waiting room" in the GH build workflow, my experience releasing Param was that I always forget clicking on the button to publish and I didn't see much benefit using it.
  • It keeps the extras in pyproject.toml and some jobs running pip, I'd like to keep the option to develop hvPlot with pip (even if undocumented), I'm concerned Pixi makes the life of re-distributors too difficult (making it less likely for hvPlot to be re-distributed).

  • Add PR description
  • Update pixi.toml to use new approach adopted by HoloViews (1 working dev env)
  • Ensure the tests / docs / build workflow work as expected
  • Update the developer guide

@maximlt maximlt marked this pull request as draft January 20, 2025 19:32
@maximlt maximlt marked this pull request as ready for review January 22, 2025 08:30
@maximlt
Copy link
Member Author

maximlt commented Jan 22, 2025

Merging while it works, can be refined later.

@maximlt maximlt merged commit fcd2403 into main Jan 22, 2025
11 checks passed
@maximlt maximlt deleted the migrate_to_pixi branch January 22, 2025 13:48
- cron: "0 0 * * *"

env:
PACKAGE: "holoviews"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hvplot

@maximlt maximlt mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants