Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement backend options transformer #653
Implement backend options transformer #653
Changes from 58 commits
56b8183
319b5fd
e143a9c
252198c
1d9090e
483fe17
1a54be5
8b728db
0cf679c
e55f467
9be1c19
ad18eeb
6fb07a9
c6bca03
79a14d4
d2cdd9d
9c788d8
77ed476
3d2c491
584fa50
4edc989
98a2cc6
4dc8378
50153c2
a11b92f
8af2196
cd75f81
31b5bc3
ab9acef
e10938b
6ce3038
a49b0e7
e9a8d36
3c6adb9
19ac0df
bd299df
a1d6f9d
3b793dc
9b616d3
62f9212
675b27f
0cf0d86
43e441a
e4615ea
5e51a0d
e0fdb84
b7527f4
3bb792d
2910d24
4de5e2f
9eecf2a
15c77f4
e0ed4fe
cf7ab64
553201b
f889457
3709775
0125c77
21fa83f
95ad501
1761fc0
affdc8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this is really related to this PR, but the lack of an x-axis label bothers me. What are the units? Absolute time or presumably time deltas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the exact same example as pandas' one, which doesn't mean it's perfect!
https://pandas.pydata.org/docs/reference/api/pandas.plotting.lag_plot.html