Skip to content

Commit

Permalink
Fix some PyCharm warnings (#7120)
Browse files Browse the repository at this point in the history
Co-authored-by: Philipp Rudiger <[email protected]>
  • Loading branch information
cdeil and philippjfr authored Aug 13, 2024
1 parent 4cf754f commit a9f8c76
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Enjoying Panel? Show your support with a [Github star](https://github.com/holovi
<tbody>
<tr>
<td>Downloads</td>
<td><a href="https://pypistats.org/packages/panel" alt="PyPi Downloads"><img src="https://img.shields.io/pypi/dm/panel?label=pypi" /></a> <a href="https://anaconda.org/pyviz/panel" alt="Conda Downloads"><img src="https://pyviz.org/_static/cache/panel_conda_downloads_badge.svg" /></a></td>
<td><a href="https://pypistats.org/packages/panel"><img src="https://img.shields.io/pypi/dm/panel?label=pypi" alt="PyPi Downloads" /></a> <a href="https://anaconda.org/pyviz/panel"><img src="https://pyviz.org/_static/cache/panel_conda_downloads_badge.svg" alt="Conda Downloads" /></a></td>
</tr>
<tr>
<td>Build Status</td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def get_apps():
return [
app
for app in glob("examples/gallery/**/*.ipynb", recursive=True)
if not app in DONT_SERVE
if app not in DONT_SERVE
]


Expand Down
2 changes: 1 addition & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ coverage:
threshold: 0.5%

comment:
require_changes: yes
require_changes: true
2 changes: 0 additions & 2 deletions examples/how_to/custom/react/material_ui.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import pathlib

import param

import panel as pn
Expand Down
1 change: 0 additions & 1 deletion panel/io/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import sys
import threading
import time
import unittest
import unittest.mock
import weakref

Expand Down
1 change: 0 additions & 1 deletion scripts/panelite/generate_panelite_content.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""
Helper script to convert and copy example notebooks into JupyterLite build.
"""
import hashlib
import json
import os
import pathlib
Expand Down
4 changes: 2 additions & 2 deletions scripts/panelite/test/test_panelite.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def get_panelite_nb_paths():
nbs = list(FILES.glob('*/*/*.ipynb')) + list(FILES.glob('*/*.*'))
for nb in nbs:
path = str(nb).replace("\\", "/").split("files/")[-1]
if path.endswith(".ipynb") and not ".ipynb_checkpoints" in path:
if path.endswith(".ipynb") and ".ipynb_checkpoints" not in path:
yield path
PATHS_WITH_NOTHING_TO_TEST = [
"gallery/demos/attractors.ipynb",
Expand All @@ -66,7 +66,7 @@ def get_panelite_nb_paths():
"gallery/demos/nyc_taxi.ipynb",
"gallery/demos/portfolio-optimizer.ipynb",
]
PATHS = list(path for path in get_panelite_nb_paths() if not path in PATHS_WITH_NOTHING_TO_TEST)
PATHS = list(path for path in get_panelite_nb_paths() if path not in PATHS_WITH_NOTHING_TO_TEST)
PATHS_WITHOUT_ISSUES = list(path for path in PATHS if path not in NOTEBOOK_ISSUES)
PATHS_WITH_ISSUES = list(path for path in PATHS if path in NOTEBOOK_ISSUES)

Expand Down

0 comments on commit a9f8c76

Please sign in to comment.