Fix race condition in periodic callback resulting in additional callback executions #5344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I am not convinced I properly ran all of the tests locally, but here is a fix that seems to be working as expected. If there is a clearer path to victory then please let me know. Fixes #5339
Not only did the location of the increment need to change, but checking the counter against the count and signaling a stop also needed to happen before the callback is executed to prevent executions from being scheduled. This now appears to work as expected for any number of threads.
The logic works as follows:
A side effect of this is that during execution of the callback, the counter has already been incremented.