Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic generate unit test matrix and add cache option #6119

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 22, 2023

See holoviz/holoviews#6043 for more details.

Built on top of #6096

image

If needed, I can also make it so that the UI test for the downstream option only runs on one OS.

@hoxbro hoxbro force-pushed the dynamic_matrix_and_cache branch from 2e67fd5 to fbf12c8 Compare December 22, 2023 15:44
@hoxbro hoxbro marked this pull request as draft December 22, 2023 15:47
@hoxbro hoxbro force-pushed the dynamic_matrix_and_cache branch from c8c40ee to 3277741 Compare December 22, 2023 16:07
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (501ebcd) 84.67% compared to head (3277741) 84.66%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           only_run_test_codechange    #6119      +/-   ##
============================================================
- Coverage                     84.67%   84.66%   -0.01%     
============================================================
  Files                           296      296              
  Lines                         44100    44076      -24     
============================================================
- Hits                          37340    37318      -22     
+ Misses                         6760     6758       -2     
Flag Coverage Δ
ui-tests 40.65% <ø> (-0.05%) ⬇️
unitexamples-tests 72.71% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as ready for review December 22, 2023 17:06
@philippjfr philippjfr merged commit c8e3853 into only_run_test_codechange Dec 26, 2023
20 of 21 checks passed
@philippjfr philippjfr deleted the dynamic_matrix_and_cache branch December 26, 2023 16:47
@hoxbro
Copy link
Member Author

hoxbro commented Dec 27, 2023

To be extra clear, this was merged into #6096. If you don't want #6096 merged, this PR will not go into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants