Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to __reduce__ when hashing classes in cache #7484

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

philippjfr
Copy link
Member

Fixes #7478

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (ce938bf) to head (bc4fa82).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7484      +/-   ##
==========================================
- Coverage   82.38%   82.38%   -0.01%     
==========================================
  Files         339      339              
  Lines       50980    50986       +6     
==========================================
+ Hits        42000    42004       +4     
- Misses       8980     8982       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit adf2774 into main Nov 12, 2024
18 checks passed
@philippjfr philippjfr deleted the cache_class_hash branch November 12, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.cache fails with hashable object
1 participant