Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FileDownload label text updates correctly #7489

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

philippjfr
Copy link
Member

Previously it would keep appending new labels.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (cd645dd) to head (415f041).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/widgets/test_misc.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7489      +/-   ##
==========================================
- Coverage   82.38%   82.38%   -0.01%     
==========================================
  Files         339      339              
  Lines       50986    50994       +8     
==========================================
+ Hits        42003    42009       +6     
- Misses       8983     8985       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 9766b6b into main Nov 13, 2024
17 checks passed
@philippjfr philippjfr deleted the download_label_text_fix branch November 13, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant