Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: websockets 14 #7491

Merged
merged 1 commit into from
Nov 14, 2024
Merged

compat: websockets 14 #7491

merged 1 commit into from
Nov 14, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 14, 2024

To fix the following warnings. By the look of it not much we can do on our end.

  File "/Users/runner/work/panel/panel/.pixi/envs/test-310/lib/python3.10/site-packages/uvicorn/protocols/websockets/auto.py", line 19, in <module>
    from uvicorn.protocols.websockets.websockets_impl import WebSocketProtocol
  File "/Users/runner/work/panel/panel/.pixi/envs/test-310/lib/python3.10/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 10, in <module>
    import websockets.legacy.handshake
  File "/Users/runner/work/panel/panel/.pixi/envs/test-310/lib/python3.10/site-packages/websockets/legacy/__init__.py", line 6, in <module>
    warnings.warn(  # deprecated in 14.0 - 2024-11-09
DeprecationWarning: websockets.legacy is deprecated; see https://websockets.readthedocs.io/en/stable/howto/upgrade.html for upgrade instructions
  File "/Users/runner/work/panel/panel/.pixi/envs/test-310/lib/python3.10/site-packages/uvicorn/protocols/websockets/auto.py", line 19, in <module>
    from uvicorn.protocols.websockets.websockets_impl import WebSocketProtocol
  File "/Users/runner/work/panel/panel/.pixi/envs/test-310/lib/python3.10/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 16, in <module>
    from websockets.server import WebSocketServerProtocol
  File "/Users/runner/work/panel/panel/.pixi/envs/test-310/lib/python3.10/site-packages/websockets/imports.py", line 86, in __getattr__
    warnings.warn(
DeprecationWarning: websockets.server.WebSocketServerProtocol is deprecated

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (cd645dd) to head (eac935e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7491   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         339      339           
  Lines       50986    50994    +8     
=======================================
+ Hits        42003    42010    +7     
- Misses       8983     8984    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 1c5abb9 into main Nov 14, 2024
18 checks passed
@philippjfr philippjfr deleted the compat_websocket branch November 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants