Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict type checking #7497

Merged
merged 34 commits into from
Dec 2, 2024
Merged

Enable strict type checking #7497

merged 34 commits into from
Dec 2, 2024

Conversation

philippjfr
Copy link
Member

  • Enforce mypy passing as a CI condition
  • Fix mypy
  • Add all optional dependencies to type checking env

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.12808% with 222 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (af3dfee) to head (16bd060).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/pyodide.py 0.00% 18 Missing ⚠️
panel/io/state.py 80.64% 18 Missing ⚠️
panel/io/resources.py 58.06% 13 Missing ⚠️
panel/io/jupyter_server_extension.py 0.00% 12 Missing ⚠️
panel/io/server.py 64.70% 12 Missing ⚠️
panel/reactive.py 81.13% 10 Missing ⚠️
panel/template/base.py 56.52% 10 Missing ⚠️
panel/io/document.py 66.66% 8 Missing ⚠️
panel/pane/base.py 63.63% 8 Missing ⚠️
panel/io/jupyter_executor.py 0.00% 7 Missing ⚠️
... and 42 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7497      +/-   ##
==========================================
- Coverage   82.30%   82.21%   -0.09%     
==========================================
  Files         339      339              
  Lines       51087    51319     +232     
==========================================
+ Hits        42049    42194     +145     
- Misses       9038     9125      +87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hoxbro
hoxbro reviewed Nov 17, 2024
View reviewed changes
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to press enter, so this is not a complete review; it's just something I did while waiting for my coffee to brew.

panel/_param.py Outdated Show resolved Hide resolved
panel/_param.py Outdated Show resolved Hide resolved
panel/chat/feed.py Outdated Show resolved Hide resolved
panel/command/convert.py Show resolved Hide resolved
panel/custom.py Show resolved Hide resolved
hoxbro
hoxbro reviewed Nov 17, 2024
View reviewed changes
panel/pane/base.py Outdated Show resolved Hide resolved
philippjfr
philippjfr commented Nov 17, 2024
View reviewed changes
panel/chat/feed.py Outdated Show resolved Hide resolved
hoxbro
hoxbro reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only reviewed up to panel/io/state.py

But submitting what I have so reviewed far.

panel/_param.py Outdated Show resolved Hide resolved
doc/generate_modules.py Outdated Show resolved Hide resolved
panel/_param.py Show resolved Hide resolved
panel/_param.py Show resolved Hide resolved
panel/chat/feed.py Outdated Show resolved Hide resolved
panel/custom.py Show resolved Hide resolved
panel/custom.py Outdated Show resolved Hide resolved
panel/io/application.py Outdated Show resolved Hide resolved
panel/io/server.py Show resolved Hide resolved
panel/io/server.py Outdated Show resolved Hide resolved
@philippjfr philippjfr enabled auto-merge (squash) November 18, 2024 20:44
@hoxbro
Copy link
Member

hoxbro commented Nov 18, 2024

Not finished with the review.

@hoxbro hoxbro disabled auto-merge November 18, 2024 20:51
hoxbro
hoxbro reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the review.

I'm not entirely sure about the changes related to class variables in _get_model, but you likely know better here.

Haven't reviewed the changes related to tests.

panel/widgets/codeeditor.py Show resolved Hide resolved
panel/_param.py Outdated Show resolved Hide resolved
panel/layout/grid.py Outdated Show resolved Hide resolved
panel/links.py Show resolved Hide resolved
panel/pane/base.py Outdated Show resolved Hide resolved
panel/pane/plotly.py Show resolved Hide resolved
panel/template/base.py Outdated Show resolved Hide resolved
panel/util/__init__.py Show resolved Hide resolved
panel/widgets/input.py Show resolved Hide resolved
panel/widgets/text_to_speech.py Outdated Show resolved Hide resolved
@philippjfr philippjfr enabled auto-merge (squash) December 2, 2024 18:18
@philippjfr philippjfr disabled auto-merge December 2, 2024 18:37
@philippjfr philippjfr merged commit 7afcc90 into main Dec 2, 2024
17 checks passed
@philippjfr philippjfr deleted the linked_props_types branch December 2, 2024 19:03
@philippjfr philippjfr mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxbro hoxbro hoxbro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @hoxbro