Enable strict type checking

doc/generate_modules.py

@@ -57,39 +57,40 @@ def write_file(name, text, opts):
     """Write the output file for module/package <name>."""
     if opts.dryrun:
         return
-    fname = os.path.join(opts.destdir, "{}.{}".format(name, opts.suffix))
+    fname = os.path.join(opts.destdir, f"{name}.{opts.suffix}")
     if not opts.force and os.path.isfile(fname):
-        print('File %s already exists, skipping.' % fname)
+        print(f'File {fname} already exists, skipping.')
     else:
-        print('Creating file %s.' % fname)
+        print(f'Creating file {fname}.')
         f = open(fname, 'w')
         f.write(text)
         f.close()
 
 def format_heading(level, text):
     """Create a heading of <level> [1, 2 or 3 supported]."""
     underlining = ['=', '-', '~', ][level-1] * len(text)
-    return '{}\n{}\n\n'.format(text, underlining)
+    return f'{text}\n{underlining}\n\n'
 
 def format_directive(module, package=None):
     """Create the automodule directive and add the options."""
-    directive = '.. automodule:: %s\n' % makename(package, module)
+    module_name = makename(package, module)
+    directive = f'.. automodule:: %s{module_name}'
     for option in OPTIONS:
-        directive += '    :%s:\n' % option
+        directive += f'    :{option}:\n'
     return directive
 
 def create_module_file(package, module, opts):
     """Build the text of the file and write the file."""
 
-    text = format_heading(1, '%s Module' % module)
-    text += format_heading(2, ':mod:`%s` Module' % module)
+    text = format_heading(1, f'{module} Module')
+    text += format_heading(2, f':mod:`{module}` Module')
     text += format_directive(module, package)
     write_file(makename(package, module), text, opts)
 
 def create_package_file(root, master_package, subroot, py_files, opts, subs):
     """Build the text of the file and write the file."""
     package = os.path.split(root)[-1]
-    text = format_heading(1, '{}.{} Package'.format(master_package, package))
+    text = format_heading(1, f'{master_package}.{package} Package')
     text += '\n---------\n\n'
     # add each package's module
     for py_file in py_files:
@@ -99,9 +100,9 @@ def create_package_file(root, master_package, subroot, py_files, opts, subs):
         py_file = os.path.splitext(py_file)[0]
         py_path = makename(subroot, py_file)
         if is_package:
-            heading = ':mod:`%s` Package' % package
+            heading = f':mod:`{package}` Package'
         else:
-            heading = ':mod:`%s` Module' % py_file
+            heading = f':mod:`{py_file}` Module'
         text += format_heading(2, heading)
         text += '\n\n'
         text += format_directive(is_package and subroot or py_path, master_package)
@@ -113,8 +114,9 @@ def create_package_file(root, master_package, subroot, py_files, opts, subs):
     if subs:
         text += format_heading(2, 'Subpackages')
         text += '.. toctree::\n\n'
+        subpackage_name = makename(master_package, subroot)
         for sub in subs:
-            text += '    {}.{}\n'.format(makename(master_package, subroot), sub)
+            text += f'    {subpackage_name}.{sub}\n'
         text += '\n'
 
     write_file(makename(master_package, subroot), text, opts)
@@ -123,9 +125,9 @@ def create_modules_toc_file(master_package, modules, opts, name='modules'):
     """
     Create the module's index.
     """
-    text = format_heading(1, '%s Modules' % opts.header)
+    text = format_heading(1, f'{opts.header} Modules')
     text += '.. toctree::\n'
-    text += '   :maxdepth: %s\n\n' % opts.maxdepth
+    text += f'   :maxdepth: {opts.maxdepth}\n\n'
 
     modules.sort()
     prev_module = ''
@@ -134,7 +136,7 @@ def create_modules_toc_file(master_package, modules, opts, name='modules'):
         if module.startswith(prev_module + '.'):
             continue
         prev_module = module
-        text += '   %s\n' % module
+        text += f'   {module}\n'
 
     write_file(name, text, opts)
 
@@ -261,9 +263,9 @@ def main():
                     excludes = normalize_excludes(rootpath, excludes)
                     recurse_tree(rootpath, excludes, opts)
                 else:
-                    print('%s is not a valid output destination directory.' % opts.destdir)
+                    print(f'{opts.destdir} is not a valid output destination directory.')
             else:
-                print('%s is not a valid directory.' % rootpath)
+                print(f'{rootpath} is not a valid directory.')
 
 
 if __name__ == '__main__':

panel/_param.py

@@ -1,17 +1,15 @@
 from __future__ import annotations
 
 from typing import (
-    TYPE_CHECKING, Any, Literal, TypeAlias, cast,
+    Any, Literal, TypeAlias, cast,
 )
 
 from bokeh.core.enums import enumeration
 from param import Parameter, _is_number
 
-if TYPE_CHECKING:
-    MarginType: TypeAlias = int | tuple[int, int] | tuple[int, int, int] | tuple[int, int, int, int]
-
 AlignmentType = Literal["auto", "start", "center", "end"]
 Alignment = enumeration(AlignmentType)
+MarginType: TypeAlias = int | tuple[int, int] | tuple[int, int, int] | tuple[int, int, int, int]
 
 
 class Align(Parameter):
@@ -87,7 +85,7 @@ def _validate_value(self, val: Any, allow_None: bool) -> None:
             )
 
     def _validate_length(self, val: Any) -> None:
-        if not isinstance(val, tuple) or (1 < len(val) < 5):
+        if not isinstance(val, tuple) or len(val) in (2, 4):
             return
         raise ValueError(
             f'Margin parameter {self.name!r} only takes integer and '

panel/chat/feed.py

@@ -851,7 +851,7 @@ def prompt_user(
         timeout_button_params : dict | None
             Additional parameters to pass to the timeout button.
         """
-        async def _prepare_prompt(*_) -> None:
+        async def _prepare_prompt(*args) -> None:
             input_button_params = button_params or {}
             if "name" not in input_button_params:
                 input_button_params["name"] = "Submit"
@@ -868,7 +868,7 @@ async def _prepare_prompt(*_) -> None:
                 send_kwargs["user"] = "Input"
             self.send(form, respond=False, **send_kwargs)
 
-            for __ in range(timeout * 10):  # sleeping for 0.1 seconds
+            for _ in range(timeout * 10):  # sleeping for 0.1 seconds
                 is_fulfilled = predicate(component) if predicate else True
                 submit_button.disabled = not is_fulfilled
                 if submit_button.clicks > 0:

panel/chat/interface.py

@@ -188,9 +188,10 @@ def _link_disabled_loading(self, obj: Viewable):
         Link the disabled and loading attributes of the chat box to the
         given object.
         """
-        for attr in ["disabled", "loading"]:
-            setattr(obj, attr, getattr(self, attr))
-            self.link(obj, callbacks=None, bidirectional=False, **{attr: attr})
+        mapping: dict[str, Any] = {"disabled": "disabled", "loading": "loading"}
+        values = {p: getattr(self, p) for p in mapping}
+        self.param.update(values)
+        self.link(obj, **mapping)
 
     @param.depends("width", watch=True)
     def _update_input_width(self):

panel/command/__init__.py

@@ -18,7 +18,7 @@
 from .oauth_secret import OAuthSecret
 from .serve import Serve
 
-description = """\
+_DESCRIPTION = """\
 Found a Bug or Have a Feature Request?
 Open an issue at: https://github.com/holoviz/panel/issues
 
@@ -66,7 +66,7 @@ def main(args: list[str] | None = None):
     from bokeh.command.subcommands import all as bokeh_commands
     parser = argparse.ArgumentParser(
         prog="panel", epilog="See '<command> --help' to read about a specific subcommand.",
-        description=description, formatter_class=argparse.RawTextHelpFormatter
+        description=_DESCRIPTION, formatter_class=argparse.RawTextHelpFormatter
     )
     parser.add_argument('-v', '--version', action='version', version=__version__)
     subs = parser.add_subparsers(help="Sub-commands")

panel/custom.py

@@ -386,7 +386,7 @@ def _update_esm(self):
 
     @property
     def _linked_properties(self) -> tuple[str, ...]:
-        return tuple(p for p in self._data_model.properties() if p not in ('js_property_callbacks',))
+        return tuple(p for p in self._data_model.properties() if p != 'js_property_callbacks')
 
     def _get_properties(self, doc: Document | None) -> dict[str, Any]:
         props = super()._get_properties(doc)

panel/io/application.py

@@ -270,8 +270,8 @@ def build_applications(
         slug = slug if slug.startswith('/') else '/'+slug
 
         # Handle other types of apps using a custom handler
-        for chandler in (custom_handlers or ()):
-            new_app = chandler(slug, app)
+        for custom_handler in (custom_handlers or ()):
+            new_app = custom_handler(slug, app)
             if app is not None:
                 break
         else:

panel/io/server.py

@@ -17,7 +17,9 @@
 from collections.abc import Callable, Mapping
 from functools import partial, wraps
 from html import escape
-from typing import TYPE_CHECKING, Any, TypedDict
+from typing import (
+    TYPE_CHECKING, Any, Literal, TypedDict,
+)
 from urllib.parse import urlparse
 
 import bokeh
@@ -611,8 +613,8 @@ class ComponentResourceHandler(StaticFileHandler):
         '_css', '_js', 'base_css', 'css', '_stylesheets', 'modifiers', '_bundle_path'
     ]
 
-    def initialize(self, path: str | None = None, default_filename: str | None = None):
-        self.root = path or 'root'
+    def initialize(self, path: str | Literal['root'] = 'root', default_filename: str | None = None):
+        self.root = path
         self.default_filename = default_filename
 
     def parse_url_path(self, path: str) -> str:

panel/models/tabulator.py

@@ -16,7 +16,7 @@
 from ..util import classproperty
 from .layout import HTMLBox
 
-TABULATOR_VERSION = "6.3.0"
+TABULATOR_VERSION = "6.2.5"
 
 JS_SRC = f"{config.npm_cdn}/tabulator-tables@{TABULATOR_VERSION}/dist/js/tabulator.min.js"
 MOMENT_SRC = f"{config.npm_cdn}/luxon/build/global/luxon.min.js"

panel/widgets/codeeditor.py

@@ -79,11 +79,10 @@ def _get_model(
         self, doc: Document, root: Model | None = None,
         parent: Model | None = None, comm: Comm | None = None
     ) -> Model:
-        if self._widget_type is None:
-            CodeEditor._widget_type = lazy_load(
-                'panel.models.ace', 'AcePlot', isinstance(comm, JupyterComm),
-                root, ext='codeeditor'
-            )
+        CodeEditor._widget_type = lazy_load(
+            'panel.models.ace', 'AcePlot', isinstance(comm, JupyterComm),
+            root, ext='codeeditor'
+        )
         return super()._get_model(doc, root, parent, comm)
 
     def _update_disabled(self, *events: param.parameterized.Event):