Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: textual 0.86 #7501

Merged
merged 1 commit into from
Nov 18, 2024
Merged

compat: textual 0.86 #7501

merged 1 commit into from
Nov 18, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 18, 2024

Taken the fix applied from Philipp here: 5218def

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (7015943) to head (7bc8797).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7501      +/-   ##
==========================================
+ Coverage   82.37%   82.38%   +0.01%     
==========================================
  Files         339      339              
  Lines       50994    50995       +1     
==========================================
+ Hits        42005    42011       +6     
+ Misses       8989     8984       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was gonna clean that up but this looks fine to me.

@philippjfr philippjfr merged commit 4da2b8e into main Nov 18, 2024
18 checks passed
@philippjfr philippjfr deleted the compat_textual branch November 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants