Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_messages kwarg to Feed.add_step #7520

Merged
merged 2 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions panel/chat/feed.py
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,7 @@ def add_step(
steps_layout: Column | Card | None = None,
default_layout: Literal["column", "card"] = "card",
layout_params: dict | None = None,
last_messages: int = 1,
**step_params
) -> ChatStep:
"""
Expand Down Expand Up @@ -750,6 +751,8 @@ def add_step(
'card' will create a new Card layout.
layout_params : dict | None
Additional parameters to pass to the layout.
last_messages: int
The number of messages to go back to find the last message.
step_params : dict
Parameters to pass to the ChatStep.
"""
Expand All @@ -771,13 +774,19 @@ def add_step(
if "context_exception" not in step_params:
step_params["context_exception"] = self.callback_exception
step = ChatStep(**step_params)

if append:
last = self._chat_log[-1] if self._chat_log else None
if last is not None and isinstance(last.object, Column) and (
for i in range(1, last_messages + 1):
if not self._chat_log:
break

last = self._chat_log[-i]
if last is not None and isinstance(last.object, Column) and (
all(isinstance(o, ChatStep) for o in last.object) or
last.object.css_classes == 'chat-steps'
) and (user is None or last.user == user):
steps_layout = last.object
) and (user is None or last.user == user):
steps_layout = last.object

if steps_layout is None:
layout_params = layout_params or {}
input_layout_params = dict(
Expand Down
28 changes: 28 additions & 0 deletions panel/tests/chat/test_feed.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,34 @@ def test_add_step_inherits_callback_exception(self, chat_feed):
raise ValueError("Testing")
assert "Traceback" in step.objects[0].object

def test_add_step_last_messages(self, chat_feed):
# create steps
with chat_feed.add_step("Object 1", title="Step 1"):
assert len(chat_feed) == 1

# add a message in the middle
chat_feed.send("Message 1")
assert len(chat_feed) == 2

# last_messages=2 should make it connect with the last steps object
with chat_feed.add_step("Object 2", title="Step 2", last_messages=2):
assert len(chat_feed) == 2
message = chat_feed[0]
steps = message.object
assert len(steps) == 2
assert steps[0].objects[0].object == "Object 1"
assert steps[1].objects[0].object == "Object 2"

# add another message
chat_feed.send("Message 2")
assert len(chat_feed) == 3

# this should now not join with the last steps object because the steps is in the first message
with chat_feed.add_step("Object 3", title="Step 3", last_messages=2):
assert len(chat_feed) == 4
steps = chat_feed[-1].object
assert len(steps) == 1

def test_stream_with_user_avatar(self, chat_feed):
user = "Bob"
avatar = "👨"
Expand Down
Loading