compat: Hatchling 1.26 #7526
Merged
compat: Hatchling 1.26 #7526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7526 +/- ##
==========================================
- Coverage 82.38% 82.37% -0.01%
==========================================
Files 339 339
Lines 50995 50995
==========================================
- Hits 42010 42008 -2
- Misses 8985 8987 +2 ☔ View full report in Codecov by Sentry. |
hoxbro
force-pushed
the
build_hatchling
branch
2 times, most recently
from
c5f4316 to
1342c64
Compare
hoxbro
force-pushed
the
build_hatchling
branch
from
1342c64 to
d5937bf
Compare
hoxbro
force-pushed
the
build_hatchling
branch
from
eb44b56 to
7127eb2
Compare
maximlt
reviewed
Nov 27, 2024
|
|
||
| from pathlib import Path | ||
|
|
||
| EXPECTED_SIZES_MB = { |
There was a problem hiding this comment.
What is the current size of these artifacts?
There was a problem hiding this comment.
I added a print statement to make this somewhat easy to get. If needed, I can output it to the Github summary.
conda file size: 21.65 MB
npm file size: 18.32 MB
sdist file size: 28.31 MB
whl file size: 26.41 MB
maximlt
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
@philippjfr when you're back, you can adjust the limits set and merged in this PR in case you think they're too high.
Current sizes:
conda file size: 21.65 MB
npm file size: 18.32 MB
sdist file size: 28.31 MB
whl file size: 26.41 MB
Limits implemented:
{
"conda": 25,
"npm": 25,
"sdist": 30,
"whl": 30,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in Hatchling 1.26.0 no longer ignore
node_modules. I think it is related to pypa/hatch#1643.List of differences in file list between this PR and 1.5.4: diff.txt