Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type check when file is passed ar requirements for convert #7566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

etihwo
Copy link

@etihwo etihwo commented Dec 21, 2024

Update script_to_html fucntion when the convert command is called with a .txt file since the commit 7afcc90 converts the requirements variable with the function pathlib.Path() when it is a .txt file.

Fixes #7565

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (d48c45f) to head (2e04569).

Files with missing lines Patch % Lines
panel/io/convert.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7566      +/-   ##
==========================================
+ Coverage   82.23%   82.24%   +0.01%     
==========================================
  Files         339      339              
  Lines       51476    51476              
==========================================
+ Hits        42330    42337       +7     
+ Misses       9146     9139       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting panel application does not accept anymore requirements.txt file:
1 participant