Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage asyncio loop creation manually #7591

Merged
merged 35 commits into from
Jan 7, 2025
Merged

Manage asyncio loop creation manually #7591

merged 35 commits into from
Jan 7, 2025

Conversation

philippjfr
Copy link
Member

Attempt at resolving current test issues. Previously we created event loops via tornado, now we manually create a new event loop and close it once we're done with it.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 98.95833% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (d48c45f) to head (35ff450).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/server.py 89.47% 2 Missing ⚠️
panel/tests/util.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7591      +/-   ##
==========================================
- Coverage   82.24%   82.11%   -0.13%     
==========================================
  Files         339      340       +1     
  Lines       51476    51477       +1     
==========================================
- Hits        42334    42271      -63     
- Misses       9142     9206      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 400cc44 into main Jan 7, 2025
18 checks passed
@philippjfr philippjfr deleted the fix_async_tests branch January 7, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant