Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dark theme scroll #7601

Merged
merged 4 commits into from
Jan 7, 2025
Merged

fix dark theme scroll #7601

merged 4 commits into from
Jan 7, 2025

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 7, 2025

Closes #7600

Don't fully understand CSS, but adding ::-webkit-scrollbar seems to make it properly use the theme's scrollbar colors

After:
image

Before:
image

With scrollbar:

image image

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (400cc44) to head (711e96b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7601   +/-   ##
=======================================
  Coverage   82.11%   82.12%           
=======================================
  Files         340      340           
  Lines       51477    51477           
=======================================
+ Hits        42271    42274    +3     
+ Misses       9206     9203    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 66905fa into main Jan 7, 2025
18 checks passed
@philippjfr philippjfr deleted the fix_dark_theme_scroll branch January 7, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChatFeed Scrollbar is not dark themed
2 participants