-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compat: Support dask query-planning, drop Python 3.9 #171
base: main
Are you sure you want to change the base?
Changes from all commits
f365d29
19afd85
43e6463
589ded7
c7f4108
fab8349
b43b4c1
f4164b3
d229062
805dbe9
3ce10db
8e1f92d
cc4aed5
7c00186
76ecbe9
2ffea47
4ccf675
7385cb8
6d5a3de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,11 +8,9 @@ install = 'python -m pip install --no-deps --disable-pip-version-check -e .' | |
|
||
[activation.env] | ||
PYTHONIOENCODING = "utf-8" | ||
DASK_DATAFRAME__QUERY_PLANNING = "False" # TODO: Support query planning | ||
USE_PYGEOS = '0' | ||
|
||
[environments] | ||
test-39 = ["py39", "test-core", "test", "test-task", "example", "test-example"] | ||
test-310 = ["py310", "test-core", "test", "test-task", "example", "test-example"] | ||
test-311 = ["py311", "test-core", "test", "test-task", "example", "test-example"] | ||
test-312 = ["py312", "test-core", "test", "test-task", "example", "test-example"] | ||
|
@@ -22,17 +20,14 @@ lint = ["py311", "lint"] | |
|
||
[dependencies] | ||
numba = "*" | ||
dask-core = "<2025.1" # TODO: Does not work with new DataFrame interface | ||
dask-core = ">=2025.1" | ||
fsspec = "*" | ||
packaging = "*" | ||
pandas = "*" | ||
pandas = ">=2.0" | ||
pip = "*" | ||
pyarrow = ">=10" | ||
pyarrow = ">=14.0.1" | ||
retrying = "*" | ||
|
||
[feature.py39.dependencies] | ||
python = "3.9.*" | ||
|
||
[feature.py310.dependencies] | ||
python = "3.10.*" | ||
|
||
|
@@ -86,6 +81,9 @@ test-unit = 'pytest spatialpandas/tests -n logical --dist loadgroup' | |
[feature.test-example.dependencies] | ||
nbval = "*" | ||
|
||
[feature.test-example.activation.env] | ||
DASK_SCHEDULER = "single-threaded" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
[feature.test-example.tasks] | ||
test-example = 'pytest -n logical --dist loadscope --nbval-lax examples' | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,14 +8,13 @@ dynamic = ["version"] | |
description = 'Pandas extension arrays for spatial/geometric operations' | ||
readme = "README.md" | ||
license = { text = "BSD-2-Clause" } | ||
requires-python = ">=3.9" | ||
requires-python = ">=3.10" | ||
authors = [{ name = "HoloViz developers", email = "[email protected]" }] | ||
maintainers = [{ name = "HoloViz developers", email = "[email protected]" }] | ||
classifiers = [ | ||
"License :: OSI Approved :: BSD License", | ||
"Development Status :: 5 - Production/Stable", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
|
@@ -27,12 +26,12 @@ classifiers = [ | |
"Topic :: Software Development :: Libraries", | ||
] | ||
dependencies = [ | ||
'dask <2025.1', | ||
'dask >=2025.1', | ||
'fsspec >=2022.8', | ||
'numba', | ||
'packaging', | ||
'pandas', | ||
'pyarrow >=10', | ||
'pandas >=2.0', | ||
'pyarrow >=14.0.1', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These two are part of the minimum dependencies of dask |
||
'retrying', | ||
] | ||
|
||
|
@@ -74,11 +73,14 @@ filterwarnings = [ | |
"ignore:datetime.datetime.utcnow():DeprecationWarning:botocore", # https://github.com/boto/boto3/issues/3889 | ||
# 2024-11 | ||
"ignore:The legacy Dask DataFrame implementation is deprecated:FutureWarning", # https://github.com/holoviz/spatialpandas/issues/146 | ||
# 2025-02 | ||
"ignore:Dask annotations ..retries.. 5. detected:UserWarning", # https://github.com/dask/dask/issues/11721 | ||
] | ||
|
||
[tool.ruff] | ||
fix = true | ||
line-length = 100 | ||
target-version = "py39" # TODO: Remove in follow up PR | ||
|
||
[tool.ruff.lint] | ||
select = [ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,25 +13,22 @@ | |
from dask import delayed | ||
from dask.dataframe.core import get_parallel_type | ||
from dask.dataframe.extensions import make_array_nonempty | ||
from dask.dataframe.partitionquantiles import partition_quantiles | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was removed when they dropped the legacy implementation: |
||
from dask.dataframe.utils import make_meta_obj, meta_nonempty | ||
from packaging.version import Version | ||
from retrying import retry | ||
|
||
try: | ||
from dask.dataframe.backends import meta_nonempty | ||
from dask.dataframe.dispatch import make_meta_dispatch | ||
except ImportError: | ||
from dask.dataframe.utils import make_meta as make_meta_dispatch, meta_nonempty | ||
|
||
from .geodataframe import GeoDataFrame | ||
from .geometry.base import GeometryDtype, _BaseCoordinateIndexer | ||
from .geoseries import GeoSeries | ||
from .spatialindex import HilbertRtree | ||
|
||
|
||
class DaskGeoSeries(dd.Series): | ||
def __init__(self, dsk, name, meta, divisions, *args, **kwargs): | ||
super().__init__(dsk, name, meta, divisions) | ||
|
||
_partition_type = GeoSeries | ||
|
||
def __init__(self, expr, *args, **kwargs): | ||
super().__init__(expr, *args, **kwargs) | ||
|
||
# Init backing properties | ||
self._partition_bounds = None | ||
|
@@ -105,8 +102,10 @@ def persist(self, **kwargs): | |
) | ||
|
||
|
||
@make_meta_dispatch.register(GeoSeries) | ||
@make_meta_obj.register(GeoSeries) | ||
def make_meta_series(s, index=None): | ||
if hasattr(s, "__array__") or isinstance(s, np.ndarray): | ||
return s[:0] | ||
result = s.head(0) | ||
if index is not None: | ||
result = result.reindex(index[:0]) | ||
|
@@ -119,13 +118,20 @@ def meta_nonempty_series(s, index=None): | |
|
||
|
||
@get_parallel_type.register(GeoSeries) | ||
def get_parallel_type_dataframe(df): | ||
def get_parallel_type_series(df): | ||
return DaskGeoSeries | ||
|
||
|
||
@dd.get_collection_type.register(GeoSeries) | ||
def get_collection_type_series(df): | ||
return DaskGeoSeries | ||
|
||
|
||
class DaskGeoDataFrame(dd.DataFrame): | ||
def __init__(self, dsk, name, meta, divisions): | ||
super().__init__(dsk, name, meta, divisions) | ||
_partition_type = GeoDataFrame | ||
|
||
def __init__(self, expr, *args, **kwargs): | ||
super().__init__(expr, *args, **kwargs) | ||
self._partition_sindex = {} | ||
self._partition_bounds = {} | ||
|
||
|
@@ -312,8 +318,9 @@ def move_retry(p1, p2): | |
ddf = self._with_hilbert_distance_column(p) | ||
|
||
# Compute output hilbert_distance divisions | ||
quantiles = partition_quantiles( | ||
ddf.hilbert_distance, npartitions | ||
from dask.dataframe.dask_expr import RepartitionQuantiles, new_collection | ||
quantiles = new_collection( | ||
RepartitionQuantiles(ddf.hilbert_distance, npartitions) | ||
).compute().values | ||
|
||
# Add _partition column containing output partition number of each row | ||
|
@@ -328,7 +335,7 @@ def move_retry(p1, p2): | |
for out_partition in out_partitions | ||
] | ||
part_output_paths = [ | ||
os.path.join(path, f"part.{int(out_partition)}.parquet") | ||
os.path.join(path, f"part.{out_partition}.parquet") | ||
for out_partition in out_partitions | ||
] | ||
|
||
|
@@ -338,7 +345,7 @@ def move_retry(p1, p2): | |
rm_retry(path) | ||
|
||
for out_partition in out_partitions: | ||
part_dir = os.path.join(path, f"part.{int(out_partition)}.parquet" ) | ||
part_dir = os.path.join(path, f"part.{out_partition}.parquet" ) | ||
mkdirs_retry(part_dir) | ||
tmp_part_dir = tempdir_format.format(partition=out_partition, uuid=dataset_uuid) | ||
mkdirs_retry(tmp_part_dir) | ||
|
@@ -360,7 +367,7 @@ def process_partition(df, i): | |
for out_partition, df_part in df.groupby('_partition'): | ||
part_path = os.path.join( | ||
tempdir_format.format(partition=out_partition, uuid=dataset_uuid), | ||
f'part{int(i)}.parquet', | ||
f'part{i}.parquet', | ||
) | ||
df_part = ( | ||
df_part | ||
|
@@ -584,8 +591,10 @@ def __getitem__(self, key): | |
return result | ||
|
||
|
||
@make_meta_dispatch.register(GeoDataFrame) | ||
@make_meta_obj.register(GeoDataFrame) | ||
def make_meta_dataframe(df, index=None): | ||
if hasattr(df, "__array__") or isinstance(df, np.ndarray): | ||
return df[:0] | ||
result = df.head(0) | ||
if index is not None: | ||
result = result.reindex(index[:0]) | ||
|
@@ -598,10 +607,14 @@ def meta_nonempty_dataframe(df, index=None): | |
|
||
|
||
@get_parallel_type.register(GeoDataFrame) | ||
def get_parallel_type_series(s): | ||
def get_parallel_type_dataframe(s): | ||
return DaskGeoDataFrame | ||
|
||
|
||
@dd.get_collection_type.register(GeoDataFrame) | ||
def get_collection_type_dataframe(df): | ||
return DaskGeoDataFrame | ||
|
||
class _DaskCoordinateIndexer(_BaseCoordinateIndexer): | ||
def __init__(self, obj, sindex): | ||
super().__init__(sindex) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dask 2025.1 only supports Python 3.10.