fixed itests

holunda-io · Apr 14, 2023 · 8521c24 · 8521c24
1 parent ab1dc86
commit 8521c24
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/components/tasklist-backend/src/main/api/openapi.yml b/components/tasklist-backend/src/main/api/openapi.yml
@@ -110,7 +110,7 @@ paths:
         '403':
           description: Not authorized.
 
-  '/task/{id}/claim':
+  '/task/{taskId}/claim':
     parameters:
       - $ref: '#/components/parameters/TaskIdParam'
       - $ref: '#/components/parameters/CurrentUserIdParam'
@@ -129,7 +129,7 @@ paths:
         '404':
           description: Task not found.
 
-  '/task/{id}/unclaim':
+  '/task/{taskId}/unclaim':
     parameters:
       - $ref: '#/components/parameters/TaskIdParam'
       - $ref: '#/components/parameters/CurrentUserIdParam'
@@ -148,7 +148,7 @@ paths:
         '404':
           description: Task not found.
 
-  '/task/{id}/defer':
+  '/task/{taskId}/defer':
     parameters:
       - $ref: '#/components/parameters/TaskIdParam'
       - $ref: '#/components/parameters/CurrentUserIdParam'
@@ -175,7 +175,7 @@ paths:
         '404':
           description: Task not found.
 
-  '/task/{id}/undefer':
+  '/task/{taskId}/undefer':
     parameters:
       - $ref: '#/components/parameters/TaskIdParam'
       - $ref: '#/components/parameters/CurrentUserIdParam'
@@ -195,7 +195,7 @@ paths:
           description: Task not found.
 
 
-  '/task/{id}/complete':
+  '/task/{taskId}/complete':
     parameters:
       - $ref: '#/components/parameters/TaskIdParam'
       - $ref: '#/components/parameters/CurrentUserIdParam'

diff --git a/.../src/test/kotlin/io/holunda/polyflow/example/tasklist/adapter/rest/impl/TaskResourceIT.kt b/.../src/test/kotlin/io/holunda/polyflow/example/tasklist/adapter/rest/impl/TaskResourceIT.kt
@@ -51,17 +51,17 @@ internal class TaskResourceIT {
   }
 
   @Test
-  fun `should fallback to current user service if no user is passed and return forbidden if the user is not found`() {
+  fun `should not allow to claim without the user header`() {
     val taskId = UUID.randomUUID().toString()
 
     whenever(taskServiceGateway.getTask(any())).thenReturn(testTask(taskId))
 
     this.mockMvc
       .perform(
-        post("${REQUEST_PATH}/task/{id}/claim", taskId)
+        post("${REQUEST_PATH}/task/{taskId}/claim", taskId)
           .servletPath(REQUEST_PATH)
       )
-      .andExpect(status().isForbidden)
+      .andExpect(status().isBadRequest)
   }
 
   @Test
@@ -72,7 +72,7 @@ internal class TaskResourceIT {
 
     this.mockMvc
       .perform(
-        post("${REQUEST_PATH}/task/{id}/claim", taskId)
+        post("${REQUEST_PATH}/task/{taskId}/claim", taskId)
           .header("X-Current-User-ID", "id1")
           .servletPath(REQUEST_PATH)
       )
@@ -90,7 +90,7 @@ internal class TaskResourceIT {
 
     this.mockMvc
       .perform(
-        post("${REQUEST_PATH}/task/{id}/claim", taskId)
+        post("${REQUEST_PATH}/task/{taskId}/claim", taskId)
           .header("X-Current-User-ID", "id1")
           .servletPath(REQUEST_PATH)
       )
@@ -109,7 +109,7 @@ internal class TaskResourceIT {
 
     this.mockMvc
       .perform(
-        post("${REQUEST_PATH}/task/{id}/unclaim", taskId)
+        post("${REQUEST_PATH}/task/{taskId}/unclaim", taskId)
           .header("X-Current-User-ID", "id1")
           .servletPath(REQUEST_PATH)
       )
@@ -130,7 +130,7 @@ internal class TaskResourceIT {
 
     this.mockMvc
       .perform(
-        post("${REQUEST_PATH}/task/{id}/defer", taskId)
+        post("${REQUEST_PATH}/task/{taskId}/defer", taskId)
           .header("X-Current-User-ID", "id1")
           .servletPath(REQUEST_PATH)
           .contentType(MediaType.APPLICATION_JSON)
@@ -151,7 +151,7 @@ internal class TaskResourceIT {
 
     this.mockMvc
       .perform(
-        post("${REQUEST_PATH}/task/{id}/undefer", taskId)
+        post("${REQUEST_PATH}/task/{taskId}/undefer", taskId)
           .header("X-Current-User-ID", "id1")
           .servletPath(REQUEST_PATH)
       )