Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dropdown for more straight-forward search mode switching #1795

Open
darkcloud784 opened this issue Dec 27, 2024 · 7 comments · May be fixed by #1807
Open

feat: add dropdown for more straight-forward search mode switching #1795

darkcloud784 opened this issue Dec 27, 2024 · 7 comments · May be fixed by #1807
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@darkcloud784
Copy link

Describe the bug

Both the search icon and the search bar won't let you type anything in them. They only give you the local results. I've even tried creating a search for the overseerr integration but that doesn't show up and again won't let you type anything in the bar.

Steps to reproduce

deploy current beta using docker compose
import your boards
try to search anything.

Impact

Makes search non-functional

Additional information

No response

Version

1.0.0-beta

Installation method

Portainer

Browser

Edge (Chromium)

@Meierschlumpf
Copy link
Member

Sorry this is not better described yet and we are still on the work of the search functionality (with for example a default search engine) When you want to use a search engine you can type a ! to see all available engines and then select one. Also you can open a list of all available shortcuts by pressing the ? while in search.

@darkcloud784
Copy link
Author

Sorry this is not better described yet and we are still on the work of the search functionality (with for example a default search engine) When you want to use a search engine you can type a ! to see all available engines and then select one. Also you can open a list of all available shortcuts by pressing the ? while in search.

Gotcha, I didn't see that in the docs so I assumed it was a bug. Might I suggest doing away with the ! or ? parameter and have the user select a "default" search. When they want to use one of other search options they can then select them from a drop down menu? Seems this would be more intuitive.

@Meierschlumpf
Copy link
Member

I guess you are most likely talking from a mobile user perspective. IMO we can add something in that direction for mobile users, but I think for desktop users it's okay that way. What do you think?

@darkcloud784
Copy link
Author

I guess you are most likely talking from a mobile user perspective. IMO we can add something in that direction for mobile users, but I think for desktop users it's okay that way. What do you think?

Personally, I think both experiences should follow eachother. So if you did this for mobile, then desktop should follow. I personally I use homarr on both desktop and mobile. I have no issues with the ! or ? parameters but I know my wife does as its not as intuitive for new or less savvy users.

@Meierschlumpf
Copy link
Member

Makes sense, okay I'll rename this issue to feat: add dropdown for more straight-forward search mode switching. Okay?

@darkcloud784
Copy link
Author

Makes sense, okay I'll rename this issue to feat: add dropdown for more straight-forward search mode switching. Okay?

Sounds good!

@Meierschlumpf Meierschlumpf changed the title bug: Search wont let you type anything feat: add dropdown for more straight-forward search mode switching Dec 27, 2024
@Meierschlumpf Meierschlumpf added enhancement New feature or request and removed needs triage labels Dec 27, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0 milestone Dec 27, 2024
@Meierschlumpf
Copy link
Member

Okay you we're actually right. You can't type anything in the home mode of the search right now. I'll fix that combined with the other thing. What do you think of something like this?

image

It has a new button in the top right corner to get to the help page (with the combinations and links to documentation and such) and below the default search engine and a possibility to open an other search engine which then opens the search engine selection?
IMO a normal dropdown does not really fit in here

@Meierschlumpf Meierschlumpf linked a pull request Dec 29, 2024 that will close this issue
4 tasks
@Meierschlumpf Meierschlumpf self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants