Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spotlight): add default search engine #1807

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Dec 29, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #1795

image

image

image

image

  • New ? button to get from home directly to help
  • New search group for default search engine with a direct connection to the search engine mode
  • Fix issue that nothing can be written when in home mode (except the special keys)

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Dec 29, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0 milestone Dec 29, 2024
@Meierschlumpf Meierschlumpf self-assigned this Dec 29, 2024
Copy link

deepsource-io bot commented Dec 29, 2024

Here's the code health analysis summary for commits f507645..ca5b8fa. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Dec 29, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.46% 7973 / 37141
🔵 Statements 21.46% 7973 / 37141
🔵 Functions 24.82% 289 / 1164
🔵 Branches 61.72% 866 / 1403
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/settings/page.tsx 0% 0% 0% 0% 1-60
apps/nextjs/src/app/[locale]/manage/settings/_components/search-settings-form.tsx 0% 0% 0% 0% 1-29
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/page.tsx 0% 0% 0% 0% 1-126
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_change-default-search-engine.tsx 0% 0% 0% 0% 1-67
packages/api/src/router/user.ts 42.33% 63.63% 100% 42.33% 82-89, 107-142, 150-158, 166-173, 186-199, 220-249, 258-262, 270-274, 277-281, 302-306, 315-374, 381-409, 418-446, 453-458, 461-473, 479-491, 494-506, 514-540, 574-578
packages/api/src/router/search-engine/search-engine-router.ts 22.72% 100% 100% 22.72% 14-31, 36-45, 49-72, 75-120, 123-135, 141-142, 148-149, 155-164, 170-191, 197
packages/db/schema/mysql.ts 100% 100% 100% 100%
packages/db/schema/sqlite.ts 100% 100% 100% 100%
packages/definitions/src/docs/homarr-docs-sitemap.ts 0% 0% 0% 0%
packages/server-settings/src/index.ts 100% 100% 100% 100%
packages/spotlight/src/components/spotlight.tsx 0% 0% 0% 0% 1-159
packages/spotlight/src/components/actions/items/group-action-item.tsx 0% 0% 0% 0% 1-56
packages/spotlight/src/lib/group.ts 0% 100% 100% 0% 39
packages/spotlight/src/lib/interaction.ts 0% 100% 100% 0% 6-59
packages/spotlight/src/modes/external/search-engines-search-group.tsx 0% 0% 0% 0% 1-284
packages/spotlight/src/modes/home/home-search-engine-group.tsx 0% 0% 0% 0% 1-173
packages/spotlight/src/modes/home/index.tsx 0% 0% 0% 0% 1-9
packages/validation/src/user.ts 100% 100% 100% 100%
Generated in workflow #4440 for commit ca5b8fa by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf changed the title feat: add default search engine feat(spotlight): add default search engine Dec 31, 2024
@Meierschlumpf Meierschlumpf marked this pull request as ready for review January 1, 2025 11:19
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 1, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add dropdown for more straight-forward search mode switching
1 participant