Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): restrict link protocols to http and https #1888

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

@Meierschlumpf Meierschlumpf self-assigned this Jan 7, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 7, 2025 22:06
Copy link

deepsource-io bot commented Jan 7, 2025

Here's the code health analysis summary for commits f4f02ca..326d39e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jan 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.25% 8016 / 37706
🔵 Statements 21.25% 8016 / 37706
🔵 Functions 24.76% 290 / 1171
🔵 Branches 61.39% 865 / 1409
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/validation/src/app.ts 100% 100% 100% 100%
packages/validation/src/integration.ts 100% 100% 100% 100%
packages/validation/src/search-engine.ts 100% 100% 100% 100%
packages/widgets/src/iframe/component.tsx 0% 0% 0% 0% 1-89
Generated in workflow #4530 for commit 326d39e by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf marked this pull request as draft January 7, 2025 22:14
@Meierschlumpf Meierschlumpf changed the title fix(security): restrict iframe protocols to http and https fix(security): restrict link protocols to http and https Jan 7, 2025
@Meierschlumpf Meierschlumpf marked this pull request as ready for review January 7, 2025 22:27
@Meierschlumpf Meierschlumpf merged commit a12dd10 into dev Jan 10, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the security-iframe-portover branch January 10, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants