Bump zwave-js to 12.2.0 and add config option for safe mode #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
suggested changes
Oct 10, 2023
raman325
changed the title
|
As discussed, the driver should expose some presets (including for the safe mode). I'll hold off on implementing that though until I have refined the unresponsive controller recovery mechanism, which might require changes to the timeouts and presets. |
|
Please undraft when the driver is ready and the PR is ready for review. |
Co-authored-by: AlCalzone <[email protected]>
raman325
changed the title
|
everything appears to be working! |
MartinHjelmare
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, users may need to adjust the length of timeouts or number of attempts configured in the driver. We therefore add a new hidden option to enable a safe mode, which, when enabled, will set some defaults for the
timeoutsandattemptsoptions.I have not validated these values with @AlCalzone yet