-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx: Update to Alpine Linux 3.20 (nginx 1.26.x) #3783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @davidrapan
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
📝 WalkthroughWalkthroughThe pull request introduces updates across multiple files related to the nginx proxy configuration. It adds a new version entry (3.11.0) to the changelog, reflecting the upgrade of Alpine Linux to version 3.20. The base images in the build configuration are also updated from version 3.19 to 3.20 for various architectures. Additionally, the version in the configuration file is updated from 3.10.1 to 3.11.0, while maintaining the existing structure and key values. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
nginx_proxy/CHANGELOG.md (1)
3-5
: Approve changes with a minor suggestion for consistency.The new changelog entry for version 3.11.0 is clear, concise, and follows the established format. The version numbering is correct, incrementing from the previous version 3.10.1.
For consistency with other entries, consider adding a blank line after the version header:
## 3.11.0 + - Update Alpine Linux to 3.20 (nginx 1.26.x)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- nginx_proxy/CHANGELOG.md (1 hunks)
- nginx_proxy/build.yaml (1 hunks)
- nginx_proxy/config.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
- nginx_proxy/build.yaml
- nginx_proxy/config.yaml
🧰 Additional context used
📓 Path-based instructions (1)
nginx_proxy/CHANGELOG.md (6)
Pattern
*/**(html|markdown|md)
: - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
Pattern
*/**(html|markdown|md)
: - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
Pattern
*/**(html|markdown|md)
: - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Pattern
*/**(html|markdown|md)
: - Use sentence-style capitalization also in headings.
Pattern
*/**(html|markdown|md)
: do not comment on HTML used for icons
Pattern
*/**(html|markdown|md)
: Avoid flagging inline HTML for embedding videos in future reviews for this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @davidrapan 👍
../Frenck
Sure thing! @frenck 😉 Should I also get rid of the deprecation warning? Looks like they moved David. |
SSIA; updates the nginx proxy add-on to Alpine Linux 3.20 (nginx 1.26.x)
Summary by CodeRabbit