Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon of 'localtuya_rc' integration #6196

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

ClusterM
Copy link
Contributor

Proposed change

Added icon for my LocalTuyaIR Remote Control integration for Home Assistant: https://github.com/ClusterM/localtuya_rc/

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/ClusterM/localtuya_rc/

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Sorry, something went wrong.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @ClusterM 👋

As this integration integrates an instance with Tuya, I would have expected the Tuya branding to be used.

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 10, 2024 11:18
@ClusterM
Copy link
Contributor Author

As this integration integrates an instance with Tuya, I would have expected the Tuya branding to be used.

Hi! Not sure that I understand you. What I need to change?

@frenck
Copy link
Member

frenck commented Dec 10, 2024

This is an integration for Tuya, so the Tuya branding is expected. This PR doesn't contain the Tuya brand.

@ClusterM
Copy link
Contributor Author

This is an integration for Tuya, so the Tuya branding is expected. This PR doesn't contain the Tuya brand.

Do I need to use the official Tuya logo? Is it legal? Do I just need to create a symlink to core_integrations/tuya? I just saw how it is implemented in other Tuya integrations, such as localtuya, and they use their own logo.

@frenck
Copy link
Member

frenck commented Dec 10, 2024

Do I need to use the official Tuya logo?

Yes

Is it legal?

Well it is what we collect here, at the same time, we also don't want to misrepresent brands, which is just a problematic.

Do I just need to create a symlink to core_integrations/tuya?

No, see also repo readme.

such as localtuya

That is odd, feel free to contribute to fix that occurrence.

../Frenck

@ClusterM
Copy link
Contributor Author

No, see also repo readme.

Oh, my bad. I understand. Fixed.

I’m sorry for wasting your time because of my lack of attention🙏

@ClusterM ClusterM requested a review from frenck December 10, 2024 12:43
@ClusterM ClusterM marked this pull request as ready for review December 10, 2024 13:50
@ClusterM
Copy link
Contributor Author

@frenck is it ok now? I just copied images from core_integrations/tuya.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ClusterM 👍

../Frenck

@frenck frenck merged commit e5a12f9 into home-assistant:master Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants