-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon of 'localtuya_rc' integration #6196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @ClusterM 👋
As this integration integrates an instance with Tuya, I would have expected the Tuya branding to be used.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi! Not sure that I understand you. What I need to change? |
This is an integration for Tuya, so the Tuya branding is expected. This PR doesn't contain the Tuya brand. |
Do I need to use the official Tuya logo? Is it legal? Do I just need to create a symlink to core_integrations/tuya? I just saw how it is implemented in other Tuya integrations, such as localtuya, and they use their own logo. |
Yes
Well it is what we collect here, at the same time, we also don't want to misrepresent brands, which is just a problematic.
No, see also repo readme.
That is odd, feel free to contribute to fix that occurrence. ../Frenck |
Oh, my bad. I understand. Fixed. I’m sorry for wasting your time because of my lack of attention🙏 |
@frenck is it ok now? I just copied images from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ClusterM 👍
../Frenck
Proposed change
Added icon for my LocalTuyaIR Remote Control integration for Home Assistant: https://github.com/ClusterM/localtuya_rc/
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)