-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom integration xiaoai_assist #6199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @duhow 👋
Custom integration are not supposed to be symlinked to the branding of a core integration. For more information, see the readme of this repository (which also describes this).
Additionally, I couldn't find the public repository providing this custom integration. Can you please point me to it?
Thanks 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Oh, I wasn't expecting to be that quick to review 😂
Gotcha. 💡 This seems to be a "candidate" for So, the custom integration is not started yet, but I'll plan to have it within the next days / weeks, I wanted to prepare the image meanwhile. Since this is Xiaomi speakers but modified with custom firmware (basically remove all internal programs and replace with custom, |
There is no brand logo for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The product image clearly shows the mi branding, can we use that instead? Otherwise, just the normal branding of Xiaomi might be a better fit.
../Frenck
Starting to develop the custom integration for integration with Home Assistant. Is there anything else missing @frenck ? 🙏🏻 |
Thanks for letting me know. I'm going to close this PR for now for that reason. Thanks! 👍 ../Frenck |
Proposed change
Adding
xiaoai_assist
icon and logo, for an upcoming integration asassist_satellite
.https://github.com/duhow/xiaoai-patch/
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)[email protected]
)logo.png
)[email protected]
)