Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom integration xiaoai_assist #6199

Closed
wants to merge 3 commits into from

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Dec 10, 2024

Proposed change

Adding xiaoai_assist icon and logo, for an upcoming integration as assist_satellite.
https://github.com/duhow/xiaoai-patch/

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/duhow/xiaoai-patch/

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @duhow 👋

Custom integration are not supposed to be symlinked to the branding of a core integration. For more information, see the readme of this repository (which also describes this).

Additionally, I couldn't find the public repository providing this custom integration. Can you please point me to it?

Thanks 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 11, 2024 07:25
@duhow
Copy link
Contributor Author

duhow commented Dec 11, 2024

Oh, I wasn't expecting to be that quick to review 😂

Custom integrations must not use Home Assistant branded images, as this might confuse the end-user into thinking that the integration is an internal/official integration.

Gotcha. 💡 This seems to be a "candidate" for validate test.

So, the custom integration is not started yet, but I'll plan to have it within the next days / weeks, I wanted to prepare the image meanwhile.

Since this is Xiaomi speakers but modified with custom firmware (basically remove all internal programs and replace with custom, mpd, snapcast, airplay), is there any suggestion for this? Can I "change colors" of the original logo, or should I come up with a new brand logo, completely unrelated to Xiaomi?

@duhow duhow marked this pull request as ready for review December 12, 2024 12:57
@home-assistant home-assistant bot requested a review from frenck December 12, 2024 12:57
@duhow
Copy link
Contributor Author

duhow commented Dec 12, 2024

There is no brand logo for xiaoai as-is, so I came up with the smart speaker as icon + Xiaomi.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product image clearly shows the mi branding, can we use that instead? Otherwise, just the normal branding of Xiaomi might be a better fit.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 12, 2024 19:27
@duhow duhow marked this pull request as ready for review December 17, 2024 13:20
@home-assistant home-assistant bot requested a review from frenck December 17, 2024 13:20
@duhow
Copy link
Contributor Author

duhow commented Dec 18, 2024

Starting to develop the custom integration for integration with Home Assistant.

image

Is there anything else missing @frenck ? 🙏🏻

@frenck
Copy link
Member

frenck commented Dec 18, 2024

So, the custom integration is not started yet, but I'll plan to have it within the next days / weeks, I wanted to prepare the image meanwhile.

Thanks for letting me know. I'm going to close this PR for now for that reason.
Please feel free to re-open when the integration is publicly available.

Thanks! 👍

../Frenck

@frenck frenck closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants