Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_component LinkStation #6202

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Add custom_component LinkStation #6202

merged 9 commits into from
Dec 11, 2024

Conversation

iKaew
Copy link
Contributor

@iKaew iKaew commented Dec 11, 2024

Proposed change

I created a custom component for Buffalo Link Station NAS, would like to have a logo for it.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/iKaew/hass-linkstation-addon

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@iKaew iKaew changed the title Added custom_component LinkStation Add custom_component LinkStation Dec 11, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @iKaew 👋

This PR contains product images (used as icons), however, that is not what we collect in this repository. Please replace the icons with the branding / brand identity of the manufacturer instead.

Thanks 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 11, 2024 07:29
@iKaew
Copy link
Contributor Author

iKaew commented Dec 11, 2024

Changed to icons.

Ref: https://www.facebook.com/BuffaloTechnologyUK

@iKaew iKaew marked this pull request as ready for review December 11, 2024 07:46
@home-assistant home-assistant bot requested a review from frenck December 11, 2024 07:46
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @iKaew 👍

../Frenck

@frenck frenck merged commit da507e4 into home-assistant:master Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants