Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brand for custom besmart thermostat integration #6207

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

coder89
Copy link
Contributor

@coder89 coder89 commented Dec 12, 2024

Proposed change

Adding BeSmart Thermostat icons for custom integration developed here:
https://github.com/coder89/ha-besmart

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@coder89 coder89 changed the title besmart thermostat icons Add brand for custom besmart thermostat integration Dec 12, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @coder89 👋

If the logo and icons are the same, the logo version can be omitted.
We will automatically fallback onto the icon in case the logo is missing.

Please remove logo files from this PR.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 12, 2024 19:41
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@coder89
Copy link
Contributor Author

coder89 commented Dec 13, 2024

Hi there @coder89 👋

If the logo and icons are the same, the logo version can be omitted. We will automatically fallback onto the icon in case the logo is missing.

Please remove logo files from this PR.

../Frenck

Hi @frenck 👋

Done. I removed logos and left only icons.

/Lukasz

@coder89 coder89 requested a review from frenck December 13, 2024 10:07
@coder89 coder89 marked this pull request as ready for review December 13, 2024 10:07
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @coder89 👍
../Frenck

@frenck frenck merged commit d641eb5 into home-assistant:master Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants