Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for "Prezzi-zonali-GME" custom integration #6211

Merged
merged 8 commits into from
Dec 16, 2024

Conversation

Gariam-1
Copy link
Contributor

@Gariam-1 Gariam-1 commented Dec 12, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Gariam-1 👋

It seems like the upload image isn't a valid image (chance the CI is also failing). Can you take a look?

Thanks! 👍

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wrong button... early morning and in need of ☕ 😬

Let me try again...

@home-assistant home-assistant bot marked this pull request as draft December 13, 2024 07:52
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Gariam-1
Copy link
Contributor Author

Hi there @Gariam-1 👋

It seems like the upload image isn't a valid image (chance the CI is also failing). Can you take a look?

Thanks! 👍

../Frenck

Hi, I initially brached this by creating an empty file to create the pzo_sensor directory, then uploaded the images here thinking they were the same place, but apparently they are not.

Now I've uploaded them correctly, but it's complaining about the x2 files. I don't know what's wrong with them, they are all png 512px. The only thing is that I used an AI upscaler for them, can this be the issue?

Thanks.

@Gariam-1 Gariam-1 marked this pull request as ready for review December 13, 2024 15:58
@home-assistant home-assistant bot requested a review from frenck December 13, 2024 15:59
@frenck
Copy link
Member

frenck commented Dec 15, 2024

CleanShot 2024-12-15 at 20 16 45

The correct filename is ending on @2x not @x2...

../Frenck

@frenck frenck marked this pull request as draft December 15, 2024 19:17
@Gariam-1
Copy link
Contributor Author

The correct filename is ending on @2x not @x2...

Oh, of course it has to be the classic stupid mistake... sorry about that.

@Gariam-1 Gariam-1 marked this pull request as ready for review December 16, 2024 02:25
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Gariam-1 👍

../Frenck

@frenck frenck merged commit 9f3458e into home-assistant:master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants