Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new eps pool control icon/logos #6224

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Conversation

robsonke
Copy link
Contributor

@robsonke robsonke commented Dec 15, 2024

Proposed change

Adding icon and logo of EPS Smart Pool Control. A Dutch supplier of pool devices. I've made a custom integration that communicates with their API: https://github.com/robsonke/eps_smart_pool_control
Just let me know if anything is wrong.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @robsonke 👋

In case the icon & logos are the same, the logo version can be omitted (we will fallback to the icon in case the logo is missing automatically).

Please remove the logo versions from this PR.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft December 15, 2024 19:50
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@robsonke
Copy link
Contributor Author

You're fast Frenck, thanks. I've removed them.

@frenck
Copy link
Member

frenck commented Dec 15, 2024

Don't forget to mark the PR "Ready for review" once you are done 👍

../Frenck

@robsonke robsonke marked this pull request as ready for review December 15, 2024 20:01
@home-assistant home-assistant bot requested a review from frenck December 15, 2024 20:01
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @robsonke 👍

../Frenck

@frenck frenck merged commit 634ff08 into home-assistant:master Dec 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants