Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise and suppress stack trace when reloading yaml fails #102410
Raise and suppress stack trace when reloading yaml fails #102410
Changes from 8 commits
9981292
9beed41
d9f3bc2
539d696
683d8d9
9b2f40c
4cec2f1
a65164c
58cf8c7
d9679fa
9bb07c9
9ebf8eb
9dbfd3d
4f95b2f
d09789e
cb0fbe8
592c854
b06d646
8ea683d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between this and the above error string? The text is too similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform_validator_unknown_err
indicates an unexpected error happened when validation a specific platform schema. I did not change the actual error messages that are in dev right now, as it breaks other tests.core/homeassistant/config.py
Lines 1228 to 1247 in 4bf2b38
platform_schema_validator_err
indicates an unexpected error happened when trying to validate against aPLATFORM_SCHEMA
.core/homeassistant/config.py
Lines 1281 to 1309 in 4bf2b38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but why does the user care? I don't see any reason to have both
platform_schema_validator_err
andplatform_validator_unknown_err
. Please remove one of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
platform_validator_unknown_err