Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config flow for Time & Date #104183

Merged
merged 20 commits into from
Jan 23, 2024
Merged

Add config flow for Time & Date #104183

merged 20 commits into from
Jan 23, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Nov 18, 2023 •
edited
Loading

Proposed change

Add config flow for Time & Date

Frontend PR with preview component: home-assistant/frontend#19476

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow has-tests integration: time_date new-feature labels Nov 18, 2023
@home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (time_date) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of time_date can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign time_date Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST gjohansson-ST mentioned this pull request Nov 18, 2023
Merged
8 tasks
@emontnemery
Copy link
Contributor

This is the third attempt (at least) of adding config flow to time and date, previous attempts:
#68627
#93320

@gjohansson-ST gjohansson-ST marked this pull request as draft November 27, 2023 21:40
@gjohansson-ST gjohansson-ST marked this pull request as ready for review December 11, 2023 22:15
@gjohansson-ST gjohansson-ST marked this pull request as draft January 2, 2024 09:00
joostlek
joostlek previously requested changes Jan 2, 2024
View reviewed changes
homeassistant/components/time_date/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/time_date/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/time_date/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/time_date/sensor.py Outdated Show resolved Hide resolved
tests/components/time_date/test_sensor.py Outdated Show resolved Hide resolved
tests/components/time_date/test_sensor.py Outdated Show resolved Hide resolved
@emontnemery emontnemery force-pushed the time_date-config-flow branch from 3483088 to bb2ff89 Compare January 2, 2024 16:31
@gjohansson-ST gjohansson-ST force-pushed the time_date-config-flow branch from 3524150 to b1a9249 Compare January 2, 2024 19:33
@emontnemery emontnemery marked this pull request as ready for review January 2, 2024 21:05
@emontnemery emontnemery marked this pull request as ready for review January 3, 2024 16:08
@gjohansson-ST gjohansson-ST marked this pull request as draft January 6, 2024 17:46
@gjohansson-ST gjohansson-ST marked this pull request as ready for review January 19, 2024 20:40
emontnemery
emontnemery requested changes Jan 22, 2024
View reviewed changes
homeassistant/components/time_date/config_flow.py

def async_config_entry_title(self, options: Mapping[str, Any]) -> str:
"""Return config entry title."""
return f"Time & Date {options[CONF_DISPLAY_OPTIONS]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title should be translated, but maybe that's not possible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible to translate the config entry title as far as I know

homeassistant/components/time_date/manifest.json Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 22, 2024 08:04
@gjohansson-ST gjohansson-ST marked this pull request as ready for review January 22, 2024 19:11
emontnemery
emontnemery approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjohansson-ST 👍

Can be merged when the frontend PR is approved

autinerd
autinerd approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@autinerd autinerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@frenck
Copy link
Member

frenck commented Jan 23, 2024

Frontend was merged 👍

@frenck frenck merged commit 65581e9 into dev Jan 23, 2024
53 checks passed
@frenck frenck deleted the time_date-config-flow branch January 23, 2024 11:18
catsmanac pushed a commit to catsmanac/ha-core-dev that referenced this pull request Jan 23, 2024
@gjohansson-ST @emontnemery @catsmanac
Add config flow for Time & Date (home-assistant#104183)
e22adf2 
Co-authored-by: Erik <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@autinerd autinerd autinerd approved these changes

@emontnemery emontnemery emontnemery approved these changes

@fabaff fabaff Awaiting requested review from fabaff fabaff is a code owner

@joostlek joostlek Awaiting requested review from joostlek

Assignees

@fabaff fabaff

Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow has-tests integration: time_date new-feature Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gjohansson-ST @emontnemery @frenck @joostlek @autinerd @fabaff