Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the GitHub config flow #105295

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Adjust the GitHub config flow #105295

merged 2 commits into from
Dec 27, 2023

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Dec 8, 2023

Proposed change

2023.12.0 showed that the progress step handling of this integration was not great, as it would no longer do anything (just keep loading forever).
While the frontend change now has been reverted, this should still change as it is a bug.

I've not marked this for the milestone as (from what I understand) the frontend change will not be re-reverted for a while.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 8, 2023

Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (github) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of github can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign github Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wondering, what part of 2023.12 did uncover that this isn't working optimal?

@ludeeus
Copy link
Member Author

ludeeus commented Dec 8, 2023

This reverts the change in the frontend that showed the problem home-assistant/frontend#18939

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 11, 2023
@frenck frenck merged commit b5012a9 into dev Dec 27, 2023
23 checks passed
@frenck frenck deleted the github-config-flow-adjust branch December 27, 2023 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants