-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate powerwall unique ids to use the gateway din #107509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the powerwall serial numbers before the api had the gateway din. Now that users have multiple gateways this is no longer unique enough. fixes #100065
Hey there @jrester, @daniel-simpson, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Works great but needs at least a test to make sure the device and one entity is migrated correctly |
bdraco
commented
Jan 10, 2024
bdraco
commented
Jan 10, 2024
bdraco
commented
Jan 10, 2024
bdraco
commented
Jan 10, 2024
|
bdraco
changed the title
Migrate powerwall unique ids use the gateway din
Migrate powerwall unique ids to use the gateway din
Jan 10, 2024
balloob
approved these changes
Jan 14, 2024
thanks |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR cannot be back-ported because its relies on previous PRs in
dev
only. Please do not tag for a patch release.Proposed change
We used the powerwall serial numbers before the api had the gateway din. Now that older firmware that doesn't expose the din isn't supported by library, and users have multiple gateways this is no longer unique enough.
fixes #100065
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: