Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bang & Olufsen add beolink grouping #113438
Bang & Olufsen add beolink grouping #113438
Changes from 59 commits
b19f5fb
ff28056
502136a
bbc062e
43b5dd1
87cd8f5
beba8f4
640f698
be0d05c
e6dbada
1c4413f
a83bf58
0b85264
bdea91b
01ef098
bea3691
95d29bf
4d85916
deafd85
26047bd
08b94a7
f940cd4
a97e978
c1a6c6d
919a747
bdcac7a
4569bea
6f45dfc
3a7ec93
a2ac751
4882f22
3cfa05b
c2583a2
fe76b2c
a82b0ca
bf04790
a8de449
92f4240
06e14a3
99ccb3a
27609c1
ed8711a
7e3e69a
70f16fc
5ec7a6e
c4eaaec
03cf63e
a64560a
91ecb4a
140273d
d517169
55d09c2
dd05859
e6a9be2
e085f78
491cb5b
1dd6cfb
45a5567
8ade5e1
199baeb
bfb70f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining what the string and bool means would be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is explained where the variable is set, is that not enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comment says:
It's still not clear to me what the key and values represent after reading that.
Maybe "Beolink expandable" has some clear meaning to you, it doesn't for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've improved the explanation now.