Add switch platform to Teslemetry #117482
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| assert_entry: bool = True, | ||
| assert_state: bool = True, |
There was a problem hiding this comment.
You have assert_entities_alt below so why do we need this?
There was a problem hiding this comment.
assert_entities_alt exists specifically to assert states in the same test that assert_entities ran. I probably could remove assert_entities_alt in a later code quality review.
The if statements in assert_entities are used in various ways in multiple other platforms.
There was a problem hiding this comment.
But don't you always want to assert the state?
And you have two different functions where one assert state and the other one assert state and entry.
So don't see why this is needed (but haven't checked the other PR's)?
Co-authored-by: G Johansson <[email protected]>
Proposed change
Add switch platform to Teslemetry
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: