Use start/stop level change to open/close Z-Wave JS Window Covering CC covers #125827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
requested changes
Sep 12, 2024
Comment on lines
+481
to
+483
| def window_covering_outbound_bottom_state_fixture(): | ||
| """Load node with Window Covering CC fixture data, with only the outbound bottom position supported.""" | ||
| return json.loads(load_fixture("zwave_js/window_covering_outbound_bottom.json")) |
There was a problem hiding this comment.
Suggested change
| def window_covering_outbound_bottom_state_fixture(): | |
| """Load node with Window Covering CC fixture data, with only the outbound bottom position supported.""" | |
| return json.loads(load_fixture("zwave_js/window_covering_outbound_bottom.json")) | |
| def window_covering_outbound_bottom_state_fixture() -> dict[str, Any]: | |
| """Load node with Window Covering CC fixture data, with only the outbound bottom position supported.""" | |
| return load_json_object_fixture("window_covering_outbound_bottom.json", DOMAIN) |
| @pytest.fixture(name="window_covering_outbound_bottom") | ||
| def window_covering_outbound_bottom_fixture( | ||
| client, window_covering_outbound_bottom_state | ||
| ): |
There was a problem hiding this comment.
Suggested change
| ): | |
| ) -> Node: |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Odd. Ruff had no changes locally. Will check again. |
MartinHjelmare
changed the title
|
Rebase on latest dev branch. I think imports have been refactored on dev. |
AlCalzone
force-pushed
the
window-covering-up-down
branch
from
1199e80 to
01681b2
Compare
|
branch rebased. I'll do the changes @joostlek requested in a followup PR because it affects all fixtures, not just the new ones. |
Co-authored-by: Martin Hjelmare <[email protected]>
joostlek
approved these changes
Sep 13, 2024
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: