Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config subentry support to entity platform #128161

Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 11, 2024

Proposed change

Add config subentry support to entity platform

This is intended as a follow-up to #117355

Needs #128155 and #128157

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery force-pushed the entity_platform_subentry_support branch 2 times, most recently from 3f1554f to 92a1ea4 Compare December 3, 2024 15:30
@emontnemery
Copy link
Contributor Author

Frontend is approved: home-assistant/frontend#23160

@emontnemery emontnemery force-pushed the entity_platform_subentry_support branch from 9e96585 to b6e661a Compare January 27, 2025 20:23
@emontnemery emontnemery changed the base branch from dev to config_subentries_feature_2 January 27, 2025 20:23
@emontnemery emontnemery marked this pull request as ready for review January 27, 2025 20:23
@emontnemery emontnemery requested a review from a team as a code owner January 27, 2025 20:23
@emontnemery emontnemery merged commit ac44daa into config_subentries_feature_2 Jan 28, 2025
46 checks passed
@emontnemery emontnemery deleted the entity_platform_subentry_support branch January 28, 2025 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants