-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appwrite integration #134249
base: dev
Are you sure you want to change the base?
Add appwrite integration #134249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ParitoshBh
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ParitoshBh. Thanks for your contribution! Could you please explain a bit what this integration is, who it would be used by and what popular use-cases could be?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@zweckj A bit of background on what Appwrite is. It is a self-hostable application that providers built in authentication, database, storage (similar to s3), functions (similar to AWS lambda), messaging and pub/sub style events. Think firebase but self-hosted. Here's the url to their landing page and github repo. This integration, in its current form, provides a service that can be used to trigger functions in Appwrite (and get response). I have been using it to pull gas prices in to home assistant which are collected from various different sources in a function that resides in Appwrite. Previously, I was using pyscript but that seemed clunky. There might be other similar use-cases. Moreover, as mentioned above, there are other things like, database, storage, etc. that haven't yet been implemented but could be in future to serve use-cases like transferring home assistant backups to storage provided by Appwrite, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the problem I have with that is, that at this point this is basically just a very generic REST API wrapper. In core, we generally try to be very specific (especially) with services. In general we try to expose as much as possible through entities and only use services, when the entities do not suffice.
So the question for me is: Can we make this more specific? Like, can you identify the objects available in appwrite and expose them through entities? Or for services can we make very specific services? I acknowlege that might be hard, but for a core integration imo we should provide more than a REST wrapper.
Yes. There are couple of ways,
I am not quite sure which one is the preferred approach but either way, it is possible to identify what all functions are available. And appreciate your time and input! |
Breaking change
Proposed change
Add Appwrite integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: