Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This change permits users to leave the nameserver field of the DNS IP integration empty, in which case the default system resolver is used.
This avoids issues where a user may have a local device they want to resolve, but the default nameserver (
208.67.222.222
/2620:119:53::53
) will not know about it. Instead the system's nameserver is now used.This will only affect new instantions of the DNSIP integration, as existing uses of those nameservers will be saved in config.
Additionally, resolver errors are now logged, meaning errors (such as in the example above) are easier to track down.
Type of change
Additional information
Happy to make tweaks to the config flow if the existing changes aren't sufficient to indicate to a user that the resolver is optional. Perhaps we have a way of surfacing the resolver errors to the user too, instead of (now) just logging.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: