-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config flow for the Flux integration #94394
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Bumping this one to be on my list again |
I discussed this PR with @balloob , @frenck and some other core developers. The concern is that the There are also a couple of well maintained and popular custom integration with more options:
@balloob thinks the functionality implemented by flux is very useful, which lines up with the popularity of the custom integrations, but he suggested a deeper integration with Home Assistant than an integration. Maybe a built-in option for lights with adjustable color-temperature to make them automatically adjust the color temperature during the day? Going in this direction would require an architecture discussion. Another view (which I personally do not share) is that the functionality provided by the flux integration is too simple and could just be replaced with a blueprint, such as this one https://community.home-assistant.io/t/advanced-circadian-lighting/383543 Until the way forward is clear, we do not want to merge this PR. |
@emontnemery Thank you for the comment. In an attempt to turn this reply into a Some context + chosen approach I know that it can be very difficult to make something "easy to use". That is why I decided to improve this integration.
The first small improvement I had in mind was this one: #93181 Apparently making yaml changes is not allowed, and a config flow is needed. (See #86201 (comment)) Suggested alternatives. I will address/discuss alternatives that were mentioned, and relate them to the context provided above.
The integrations seem really good, but sadly they need to be installed using HACS.
As stated earlier I don't feel I have the knowledge to implement architecture changes. The Concern
I don't know what the "known issues and limitations" of Proposed way forward:
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Hi there @schelv As pointed out correctly above, we indeed don't want to move forward with this at this point. You ask about the issues with this integration; there are quite a few (especially when working with multiple light sources), but also feature completeness. From as user perspective point of view, eventually, we don't want this to be an integration that provides a "device automation"-as-integration, but a native, built-in part of just lights in Home Assistant. In the end, wrapping a light in an integration to automate stuff like this is odd. For that same reason, we don't want to level up a few more of these integrations (like alert and device_sun_light_trigger). Nevertheless, thanks for being willing to contribute ❤️ ../Frenck |
Proposed change
I've made some key improvements to the Flux integration:
Improvements:
brightness
anddisable_brightness_adjust
into one UI option, "Adjust Brightness".Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: