Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mqtt_basic_async example conf handling #69

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

shanx
Copy link
Contributor

@shanx shanx commented Aug 4, 2024

Add domain in the config schema

Add domain in the config schema
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shanx

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft August 4, 2024 09:50
@home-assistant
Copy link

home-assistant bot commented Aug 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@shanx
Copy link
Contributor Author

shanx commented Aug 4, 2024

Signed CLA

@shanx shanx marked this pull request as ready for review August 4, 2024 09:52
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

CI failure is unrelated to this PR.

@MartinHjelmare MartinHjelmare merged commit 8cbb703 into home-assistant:master Aug 5, 2024
1 of 2 checks passed
@shanx shanx deleted the patch-1 branch September 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants