Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigEntry runtime_data in detailed hello world #70

Conversation

HipsterBrown
Copy link
Contributor

Based on the change to the ConfigEntry usage described in this developer docs blog post, integrations can/should extend the ConfigEntry type to store custom data as the runtime_data field to be accessed by platforms and services associated with that entry.

This PR updates the detailed_hello_world_push example to demonstrate this new pattern.

@home-assistant home-assistant bot marked this pull request as draft August 17, 2024 21:43
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare MartinHjelmare changed the title refactor(detailed_hello_world): use custom ConfigEntry runtime_data Use ConfigEntry runtime_data in detailed hello world Aug 17, 2024
@HipsterBrown HipsterBrown force-pushed the nhehr/config_entry_runtime_data branch from 5b32f0c to 6816f75 Compare August 20, 2024 20:45
@HipsterBrown HipsterBrown marked this pull request as ready for review August 20, 2024 20:45
@HipsterBrown
Copy link
Contributor Author

Thanks for the review, @MartinHjelmare! 👍

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

CI failure is unrelated.

@MartinHjelmare MartinHjelmare merged commit 54d666d into home-assistant:master Aug 20, 2024
1 of 2 checks passed
@HipsterBrown HipsterBrown deleted the nhehr/config_entry_runtime_data branch August 20, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants