Use finishes_at in timer remaining calculation (#22169)

* Use finishes_at in timer remaining calculation * lint * fix test
home-assistant · Oct 1, 2024 · ce9993f · ce9993f
1 parent 4c2044e
commit ce9993f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/data/timer.ts b/src/data/timer.ts
@@ -72,8 +72,8 @@ export const timerTimeRemaining = (
 
   if (stateObj.state === "active") {
     const now = new Date().getTime();
-    const madeActive = new Date(stateObj.last_changed).getTime();
-    timeRemaining = Math.max(timeRemaining - (now - madeActive) / 1000, 0);
+    const finishes = new Date(stateObj.attributes.finishes_at).getTime();
+    timeRemaining = Math.max((finishes - now) / 1000, 0);
   }
 
   return timeRemaining;

diff --git a/test/common/entity/timer_time_remaining_test.ts b/test/common/entity/timer_time_remaining_test.ts
@@ -42,8 +42,8 @@ describe("timerTimeRemaining", () => {
           state: "active",
           attributes: {
             remaining: "0:01:05",
+            finishes_at: "2018-01-17T16:16:17+00:00",
           },
-          last_changed: "2018-01-17T16:15:12Z",
         } as any),
         47
       );