fix valve entities row (#19278)

home-assistant · Jan 4, 2024 · ecadc06 · ecadc06
1 parent e5d31d8
commit ecadc06
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/common/const.ts b/src/common/const.ts
@@ -254,6 +254,7 @@ export const DOMAINS_INPUT_ROW = [
   "text",
   "time",
   "vacuum",
+  "valve",
 ];
 
 /** States that we consider "off". */

diff --git a/src/data/valve.ts b/src/data/valve.ts
@@ -14,14 +14,20 @@ export const enum ValveEntityFeature {
 }
 
 export function isFullyOpen(stateObj: ValveEntity) {
-  if (stateObj.attributes.current_position !== undefined) {
+  if (
+    stateObj.attributes.current_position !== undefined &&
+    stateObj.attributes.current_position !== null
+  ) {
     return stateObj.attributes.current_position === 100;
   }
   return stateObj.state === "open";
 }
 
 export function isFullyClosed(stateObj: ValveEntity) {
-  if (stateObj.attributes.current_position !== undefined) {
+  if (
+    stateObj.attributes.current_position !== undefined &&
+    stateObj.attributes.current_position !== null
+  ) {
     return stateObj.attributes.current_position === 0;
   }
   return stateObj.state === "closed";
-Original file line number
+Diff line change
@@ Expand Up / @@ -254,6 +254,7 @@ export const DOMAINS_INPUT_ROW = [ @@
       "text",
       "time",
       "vacuum",
+      "valve",
     ];
     /** States that we consider "off". */
@@ Expand Down @@