Don't use duration formatting for second unit (#23132)

Don't use duration formatting for sec unit
home-assistant · Dec 4, 2024 · f8ce7c2 · f8ce7c2
1 parent af1622e
commit f8ce7c2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 23 deletions.
diff --git a/src/common/datetime/format_duration.ts b/src/common/datetime/format_duration.ts
@@ -71,7 +71,7 @@ export const formatDurationDigital = (
   duration: HaDurationData
 ) => formatDigitalDurationMem(locale).format(duration);
 
-export const DURATION_UNITS = ["s", "min", "h", "d"] as const;
+export const DURATION_UNITS = ["min", "h", "d"] as const;
 
 type DurationUnit = (typeof DURATION_UNITS)[number];
 
@@ -99,14 +99,6 @@ const formatDurationMinuteMem = memoizeOne(
     })
 );
 
-const formatDurationSecondMem = memoizeOne(
-  (locale: FrontendLocaleData) =>
-    new Intl.DurationFormat(locale.language, {
-      style: "narrow",
-      secondsDisplay: "always",
-    })
-);
-
 export const formatDuration = (
   locale: FrontendLocaleData,
   duration: string,
@@ -146,15 +138,6 @@ export const formatDuration = (
       };
       return formatDurationMinuteMem(locale).format(input);
     }
-    case "s": {
-      const seconds = Math.floor(value);
-      const milliseconds = Math.floor((value - seconds) * 1000);
-      const input: DurationInput = {
-        seconds,
-        milliseconds,
-      };
-      return formatDurationSecondMem(locale).format(input);
-    }
     default:
       throw new Error("Invalid duration unit");
   }

diff --git a/test/common/datetime/format_duration.test.ts b/test/common/datetime/format_duration.test.ts
@@ -21,11 +21,6 @@ const LOCALE: FrontendLocaleData = {
 
 describe("formatDuration", () => {
   it("works", () => {
-    assert.strictEqual(formatDuration(LOCALE, "0.5", "s"), "0s 500ms");
-    assert.strictEqual(formatDuration(LOCALE, "1", "s"), "1s");
-    assert.strictEqual(formatDuration(LOCALE, "1.1", "s"), "1s 100ms");
-    assert.strictEqual(formatDuration(LOCALE, "65", "s"), "65s");
-
     assert.strictEqual(formatDuration(LOCALE, "0.25", "min"), "0m 15s");
     assert.strictEqual(formatDuration(LOCALE, "0.5", "min"), "0m 30s");
     assert.strictEqual(formatDuration(LOCALE, "1", "min"), "1m");