Add support for state content customization in tile card #18180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Oct 10, 2023
bramkragten
reviewed
Oct 10, 2023
| private async _createSortable() { | ||
| const Sortable = await loadSortable(); | ||
| this._sortable = new Sortable( | ||
| this.shadowRoot!.querySelector("ha-chip-set")!, |
There was a problem hiding this comment.
We should probably also add sort support to the checkbox option then?
There was a problem hiding this comment.
I think we should force the dropdown layout if reorder selector option is true. We already do that if there is a custom value. Reordering checkbox is weird.
piitaya
force-pushed
the
tile-card-state-content
branch
3 times, most recently
from
4e9955c to
b920cda
Compare
|
@bramkragten I also added a |
piitaya
force-pushed
the
tile-card-state-content
branch
2 times, most recently
from
e8f6eba to
50fe8fd
Compare
8 tasks
frenck
added
the
Noteworthy
bramkragten
reviewed
Oct 23, 2023
| this.selector.select?.reorder | ||
| ) { | ||
| this._createSortable(); | ||
| } else if (!this.value?.length && this._sortable) { |
There was a problem hiding this comment.
Suggested change
| } else if (!this.value?.length && this._sortable) { | |
| } else if (this._sortable && (!this.selector.select?.reorder || !this.value?.length)) { |
bramkragten
previously approved these changes
Oct 23, 2023
piitaya
force-pushed
the
tile-card-state-content
branch
from
039bb3b to
1dcb95e
Compare
bramkragten
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card
The state can be replaced by one or multiple attribute to avoid the usage of templating.
stateandlast-changedkey are allowed too. An option as been added to totally state the state.Config
Two new options has been added.
Editor
The editor uses a multiple select to let the user choose attributes. Items are draggable for re-ordering.
Demo
CleanShot.2023-10-16.at.14.45.23.mp4
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: