-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RelativeCI input issues #18196
Fix RelativeCI input issues #18196
Conversation
I think that part is fine, but this is not: For legacy builds, it is not working, this might be because it uses the same artifact as the modern build?
It is trying to get wrong json file, this should be
|
I has become try and catch anyway. Next one:
|
Yeah this one should be reverted. I think you're right and it doesn't like that I put both in one artifact for whatever reason. I think I can fix it. |
@bramkragten try renaming the secrets with the slug part as lowercase (e.g. RELATIVE_CI_KEY_frontend_modern). The docs say secret names are case-insensitive, but maybe not so much. There's no easy string function to make them uppercase in GH expressions, and adding a script step just for that seems overkill. |
Also should probably set |
I think it's working now. Are these stats somewhere publicly available? |
Almost... Bram and I are going back and forth on this and RelativeCI stepped in to help too. Trying to get reports on PR pages working. |
Proposed change
I've looked into the github action code and it seems like they no longer use the artifactwebpackstatsfile input:
https://github.com/relative-ci/agent-action/blob/5a64b486a2d123f21dda6780236f2de9b18bf478/src/index.ts#L46C47-L46C47
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: